improvement: cancel current request in batched functions #5432
Conversation
kasiaMarek
changed the title
kasiaMarek
force-pushed
the
batch-function-cancel
branch
4 times, most recently
from
ce3c761 to
bc0c04a
Compare
| } | ||
| .distinct | ||
| .foreach { conn => | ||
| conn.cancelCompilations() |
There was a problem hiding this comment.
I think this was done on purpose since the cancelation was not properly propagated before
metals/src/main/scala/scala/meta/internal/metals/BatchedFunction.scala
Outdated
Show resolved
Hide resolved
| if (!queue.isEmpty) { | ||
| runAcquire() | ||
| } | ||
| } | ||
| private def runAcquire(): Unit = { | ||
| if (!isPaused.get() && lock.compareAndSet(false, true)) { | ||
| runRelease() | ||
| val id = rand.nextInt() |
There was a problem hiding this comment.
Random could be zero,no? This should probably be a raising number. Why do we need the additional int though?
There was a problem hiding this comment.
Before cancel() would clear the queue and do unlock(). But we still may get a response from the request that was currently processed, which would also do ulock() as callback. We are loosing control over the lock a bit. Not sure if that is a real problem though. Now when we also do cancel on the currently processed request, we have no guarantee the futures underneath will actually react to cancel, so I'm making sure that only the non-cancelled currently processed request will have onComplete executed. There is most probably a better way to do this.
kasiaMarek
force-pushed
the
batch-function-cancel
branch
2 times, most recently
from
40c1b48 to
4679686
Compare
kasiaMarek
force-pushed
the
batch-function-cancel
branch
from
d0d21fe to
956a014
Compare
metals/src/main/scala/scala/meta/internal/metals/BatchedFunction.scala
Outdated
Show resolved
Hide resolved
| ) | ||
| .zip { | ||
| // wait until the compilation start | ||
| Thread.sleep(1000) |
There was a problem hiding this comment.
Could this have a potential to be flaky? A compilation might take less than that, no? You could try some macros that do Thread.sleep to make sure
kasiaMarek
force-pushed
the
batch-function-cancel
branch
from
956a014 to
af79a8e
Compare
kasiaMarek
force-pushed
the
batch-function-cancel
branch
from
af79a8e to
b1e86f0
Compare
No description provided.